D11012: Add Trash (empty, isEmpty, emptinessChanged)

Mark Gaiser noreply at phabricator.kde.org
Sun Mar 11 12:45:43 GMT 2018


markg accepted this revision.
markg added a comment.


  Please do the next patch in a way that we can actually see what's happening, that's for D11216 <https://phabricator.kde.org/D11216>. I'd recommend following what @rkflx said for followup patches.
  
  For this patch, i did actually test it now and it works as advertised. Aka, it works as it did before, only now with the Trash class.
  I'm fine with shipping it. @elvisangelaccio, do you have more comments or a +1 otherwise?
  
  Note: I'm not a Dolphin maintainer! But if multiple people agree with this change it's imho fine as well.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11012

To: rominf, elvisangelaccio, markg, ngraham
Cc: ngraham, markg, rkflx, elvisangelaccio, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180311/94a2f141/attachment.htm>


More information about the kfm-devel mailing list