D11012: Add Trash (empty, isEmpty, emptinessChanged)

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> placesitem.cpp:24
>  #include "placesitem.h"
> +#include "placesitemsignalhandler.h"
> +#include "trash/dolphintrash.h"

Not needed, please remove.

> placespanel.cpp:433
> -    }
> -    // as long as KIO doesn't do this, do it ourselves
> -    KNotification::event(QStringLiteral("Trash: emptied"), QString(), QPixmap(), nullptr, KNotification::DefaultEvent);

Please don't discard this comment, let's keep it even in the new file.

> dolphintrash.cpp:2
> +/***************************************************************************
> + *   Copyright (C) 2018 by Roman Inflianskas <infroma at gmail.com>           *
> + *                                                                         *

Please also add

  Copyright (C) 2012 by Peter Penz <peter.penz19 at gmail.com>  

who is the original author of a part of this code.

> dolphintrash.h:40-41
> +    static Trash& instance();
> +    KIO::Job* empty(QWidget *window);
> +    bool isEmpty();
>  

These methods don't use `m_trashDirLister`, right? => they should be `static`

> dolphintrash.h:46-48
> +protected:
> +    Trash();
> +    ~Trash();

Why `protected` instead of `private`?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11012

To: rominf, elvisangelaccio, markg, ngraham
Cc: ngraham, markg, rkflx, elvisangelaccio, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180311/f443fc22/attachment.htm>