D11048: Convert hard coded shortcuts to standard keys

Chris Rizzitello noreply at phabricator.kde.org
Mon Mar 5 18:12:51 GMT 2018


rizzitello added inline comments.

INLINE COMMENTS

> rominf wrote in dolphinmainwindow.cpp:1059
> As written in https://doc.qt.io/qt-5/qkeysequence.html#details `QKeySequence::AddTab` = [Ctrl] + [T] for all DE, except KDE ([Ctrl] + [⇧] + [N]; [Ctrl] + [T]). But in practice, only the first sequence ([Ctrl] + [⇧] + [N]) works. In my opinion [Ctrl] + [T] should work for KDE too, hence the code.

I agree that Ctrl+T should be our main shortcut. This looks like a work around for a Qt bug now so I get why we are sending both. Maybe we should talk with Qt about resolving this bug?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11048

To: rominf, #dolphin, rizzitello
Cc: rizzitello, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180305/698423bb/attachment.htm>


More information about the kfm-devel mailing list