D11048: Convert hard coded shortcuts to standard keys

Roman Inflianskas noreply at phabricator.kde.org
Mon Mar 5 19:51:31 GMT 2018


rominf added inline comments.

INLINE COMMENTS

> rizzitello wrote in dolphinmainwindow.cpp:1059
> I agree that Ctrl+T should be our main shortcut. This looks like a work around for a Qt bug now so I get why we are sending both. Maybe we should talk with Qt about resolving this bug?

I'm not sure that it's Qt bug. It can be the bug of kxmlgui (`actionCollection()->setDefaultShortcut()`). I wanted to verify this, but couldn't build it on my openSUSE, because it has `extra-cmake-modules` version 5.43, while kxmlgui requires 5.44.

If you have a chance, please, try it.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11048

To: rominf, #dolphin, rizzitello
Cc: rizzitello, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180305/e3acc6c4/attachment.htm>


More information about the kfm-devel mailing list