D11048: Convert hard coded shortcuts to standard keys

Roman Inflianskas noreply at phabricator.kde.org
Mon Mar 5 17:39:17 GMT 2018


rominf added inline comments.

INLINE COMMENTS

> rizzitello wrote in dolphinmainwindow.cpp:1059
> QKeySequence::AddTab == Ctrl + T . 
> Do we want to always force Crtl+T for new tab or only the set KeySequence?

As written in https://doc.qt.io/qt-5/qkeysequence.html#details `QKeySequence::AddTab` = [Ctrl] + [T] for all DE, except KDE ([Ctrl] + [⇧] + [N]; [Ctrl] + [T]). But in practice, only the first sequence ([Ctrl] + [⇧] + [N]) works. In my opinion [Ctrl] + [T] should work for KDE too, hence the code.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D11048

To: rominf, #dolphin, rizzitello
Cc: rizzitello, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180305/7f58f168/attachment.htm>


More information about the kfm-devel mailing list