D10995: Fix some compile warnings
Roman Inflianskas
noreply at phabricator.kde.org
Mon Mar 5 08:01:07 GMT 2018
rominf added inline comments.
INLINE COMMENTS
> markg wrote in phononwidget.cpp:26-29
> -1
>
> Those are GCC specific (what about clang and MSVC?).
> Phonon is the place to fix that. If that isn't ready yet then we just have those compile warnings.
>
> At least, that's my opinion, not sure about others.
I don't think that there is a cross-compiler way of ignoring warnings. In my opinion is better to make the code more ugly but to get rid of all warnings, because it's easier to spot a warning when it's only the one.
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D10995
To: rominf, #dolphin, markg
Cc: rkflx, elvisangelaccio, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180305/c604d93e/attachment.htm>
More information about the kfm-devel
mailing list