D10995: Fix some compile warnings

[Mark Gaiser]

markg requested changes to this revision.
markg added a comment.
This revision now requires changes to proceed.


  Could you not do this please?
  The revision i reviewed was a lot different then the one that's up now. You even fix different things compared to what i first saw.
  This should have been a new review i think, not an update.

INLINE COMMENTS

> rkflx wrote in phononwidget.cpp:26-29
> Was this part of the original Diff people reviewed?

Nope...

> phononwidget.cpp:26-29
> +#pragma GCC diagnostic push                          // Phonon doesn't use C++11 compiler by default, so override
> +#pragma GCC diagnostic ignored "-Wsuggest-override"  // specifier is not available. Remove this pragmas after fixing it.
>  #include <Phonon/VideoWidget>
> +#pragma GCC diagnostic pop

-1

Those are GCC specific (what about clang and MSVC?).
Phonon is the place to fix that. If that isn't ready yet then we just have those compile warnings.

At least, that's my opinion, not sure about others.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10995

To: rominf, #dolphin, markg
Cc: rkflx, elvisangelaccio, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180304/7318d858/attachment.htm>