D10995: Fix some compile warnings

[Mark Gaiser]

markg added inline comments.

INLINE COMMENTS

> rominf wrote in phononwidget.cpp:26-29
> I don't think that there is a cross-compiler way of ignoring warnings. In my opinion is better to make the code more ugly but to get rid of all warnings, because it's easier to spot a warning when it's only the one.

I usually tend to agree to changes that reduce compile warnings as i hate warnings too.
But in this case i see no real benefit for a mere 2 warnings less on one compiler.

In fact, adding override in phonon (to Phonon::VideoWidget::mouseMoveEvent and Phonon::VideoWidget::event would solve it, but it's probably not that easy).

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10995

To: rominf, #dolphin, markg
Cc: rkflx, elvisangelaccio, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180305/f9f9aa8e/attachment.htm>