D12571: Modernize Settings window

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  In D12571#276764 <https://phabricator.kde.org/D12571#276764>, @ngraham wrote:>
  
  > Don't they control how the view appears on startup?
  
  
  Only "Split view mode" does. The other ones control things that are outside the view. How about using "On startup:" and rewording the sentences on the checkboxes where necessary?
  
  Other comments on the UI before looking at the code:
  
  - In the Startup page, what does "Location" refer to? The groupbox made it clear it was the Home folder, now we are hiding this information.
  - In the View Modes page: "Expandable folders: [] Enable" => do we really have to? :(
  - The Confirmation tab now is better but still confusing. I don't see why we need to touch it at all honestly, given that there are only checkboxes in there.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D12571

To: ngraham, #dolphin, #vdg, broulik, elvisangelaccio
Cc: medhefgo, zzag, rkflx, kfm-devel, elvisangelaccio, abetts, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180613/c64c1bd3/attachment.htm>