D12571: Modernize Settings window

Nathaniel Graham noreply at phabricator.kde.org
Sun Jun 10 23:12:34 BST 2018


ngraham added a comment.


  @elvisangelaccio this is ready for review again. Now all it does is change the layout on pages that have mixed controls (checkboxes, radio buttons, and comboboxes etc) for which the new design has the label on the left. I've moved the Use Default Location button removal change to D13474 <https://phabricator.kde.org/D13474>. I've also abandoned the `KMessageWidget` change since I couldn't get it work work properly when pressing the OK button; the windows always closes and the message isn't displayed.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D12571

To: ngraham, #dolphin, #vdg, broulik, elvisangelaccio
Cc: medhefgo, zzag, rkflx, kfm-devel, elvisangelaccio, abetts, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180610/982e1d2f/attachment.htm>


More information about the kfm-devel mailing list