D14452: Fixes memory leak of DolphinMainWindow

Elvis Angelaccio noreply at phabricator.kde.org
Sun Jul 29 19:31:13 BST 2018


elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  `QPointer` is not a smart pointer and doesn't handle memory. But we don't need it anyway, because we have the `Qt::WA_DeleteOnClose` attribute set which does the cleanup.
  
  I think this is just a false positive from ASAN, since `Qt::WA_DeleteOnClose`  is a Qt-specific thing that ASAN probably doesn't know.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D14452

To: hallas, elvisangelaccio
Cc: elvisangelaccio, kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180729/9fe20525/attachment.htm>


More information about the kfm-devel mailing list