D14452: Fixes memory leak of DolphinMainWindow

David Hallas noreply at phabricator.kde.org
Sun Jul 29 11:09:01 BST 2018


hallas created this revision.
Restricted Application added a project: Dolphin.
Restricted Application added a subscriber: kfm-devel.
hallas requested review of this revision.

REVISION SUMMARY
  Fixes memory leak of DolphinMainWindow
  In the main function the DolphinMainWindow was stored in a plain old
  pointer causing it to be leaked, instead keep it in a QPointer so
  we are sure it is correctly freed when the application exists.

TEST PLAN
  This leak was found using Address Sanitizer

REPOSITORY
  R318 Dolphin

BRANCH
  fixes_leak_of_main_window (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14452

AFFECTED FILES
  src/main.cpp

To: hallas
Cc: kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180729/078f2cc2/attachment.htm>


More information about the kfm-devel mailing list