D14452: Fixes memory leak of DolphinMainWindow

[David Hallas]

hallas abandoned this revision.
hallas added a comment.


  In D14452#300172 <https://phabricator.kde.org/D14452#300172>, @elvisangelaccio wrote:
  
  > `QPointer` is not a smart pointer and doesn't handle memory. But we don't need it anyway, because we have the `Qt::WA_DeleteOnClose` attribute set which does the cleanup.
  >
  > I think this is just a false positive from ASAN, since `Qt::WA_DeleteOnClose`  is a Qt-specific thing that ASAN probably doesn't know.
  
  
  Yes, you are right. I can see from testing that I have mixed up my changes a little bit :)
  
  Closing this one...

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D14452

To: hallas, elvisangelaccio
Cc: elvisangelaccio, kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180729/2e93aa26/attachment.htm>