D10804: Show "Empty Trash" button inside trash directory

Nathaniel Graham noreply at phabricator.kde.org
Tue Feb 27 14:53:56 GMT 2018


ngraham added a comment.


  Ditto everything @rkflx said. But we're getting there!

INLINE COMMENTS

> rkflx wrote in dolphinviewcontainer.cpp:95
> Won't do a full code review for Dolphin related patches, but this should just use the same icon as everywhere in Dolphin: `user-trash`.

yeah, listen to Henrik here. This was my bad; we have since determined that we should //not// be using the `-symbolic` icons. See D10770#213782 <https://phabricator.kde.org/D10770#213782>

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10804

To: rominf, #dolphin, #kde_applications, ngraham, rkflx
Cc: emateli, broulik, elvisangelaccio, rkflx, mmustac, ngraham, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180227/3f045a2f/attachment.htm>


More information about the kfm-devel mailing list