D10804: Show "Empty Trash" button inside trash directory

[Henrik Fehlauer]

rkflx added inline comments.

INLINE COMMENTS

> ngraham wrote in dolphinviewcontainer.cpp:95
> yeah, listen to Henrik here. This was my bad; we have since determined that we should //not// be using the `-symbolic` icons. See D10770#213782 <https://phabricator.kde.org/D10770#213782>

…because only few icon sets contain this icon. Nevertheless, the HiDPI problem still stands. Perhaps as a workaround we can replicate D10843 <https://phabricator.kde.org/D10843>, i.e. use another icon (providing the same line weight, which `-symbolic` lacks) and add a fallback.

However, better to use `user-trash` here, and do the workaround in a follow-up patch (to keep `git log` clean and change it everywhere at once).

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10804

To: rominf, #dolphin, #kde_applications, ngraham, rkflx
Cc: emateli, broulik, elvisangelaccio, rkflx, mmustac, ngraham, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180227/65b9efca/attachment.htm>