D10832: Replace all enum to enum class
Henrik Fehlauer
noreply at phabricator.kde.org
Sun Feb 25 17:23:09 GMT 2018
rkflx added a comment.
Late to the party, here are my thoughts:
There's some value in the explicitness `enum class` sometimes provides, but counteracting it immediately with `static_cast` is not really useful.
I'd vote to apply this to new code only for now. Speaking from recent experience, it's easy to get things wrong regarding an `enum` refactoring ;) Better not to perform a mass change, unless there is a reviewer checking very thoroughly (I won't).
REPOSITORY
R318 Dolphin
REVISION DETAIL
https://phabricator.kde.org/D10832
To: rominf, #dolphin
Cc: elvisangelaccio, markg, rkflx, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180225/e1299528/attachment.htm>
More information about the kfm-devel
mailing list