D10832: Replace all enum to enum class

[Roman Inflianskas]

rominf added a comment.


  In D10832#213781 <https://phabricator.kde.org/D10832#213781>, @rkflx wrote:
  
  > Late to the party, here are my thoughts:
  >
  > There's some value in the explicitness `enum class` sometimes provides, but counteracting it immediately with `static_cast` is not really useful.
  >
  > I'd vote to apply this to new code only for now. Speaking from recent experience, it's easy to get things wrong regarding an `enum` refactoring ;) Better not to perform a mass change, unless there is a reviewer checking very thoroughly (I won't).
  
  
  Another variant is to apply only obvious changes and skip all changes that require `static_cast`s. It's not hard to do (I need just filter my changes), easy to check for a reviewer (verify that `(X)SomethingPostfix -> X::Something`) and better than nothing.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D10832

To: rominf, #dolphin
Cc: elvisangelaccio, markg, rkflx, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180225/cf318d92/attachment.htm>