D7423: [WIP/assistance needed] Populate UDS_CREATION_TIME on Linux if statx system call is available

[Rolf Eike Beer]

dakon added inline comments.

INLINE COMMENTS

> CMakeLists.txt:14
> +  check_function_exists(statx HAVE_STATX)
> +  set(HAVE_STATX ${HAVE_STATX})
>  endif()

This line looks needless.

> file.cpp:86
> +#include <sys/syscall.h>
> +// 332 on my system
> +#define STAT(path, buf) syscall(__NR_statx,(AT_FDCWD),(path),(AT_SYMLINK_NOFOLLOW),(0),(buf))

This comment isn't needed either.

> file.cpp:950
>  #endif
> +#ifdef stx_btime
> +        /* As above, but it's called "stx_btime" in Linux kernel 4.11+

Where would that define come from? At least on glibc 2.28 I see it nowhere defined.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7423

To: ngraham, dfaure, broulik, elvisangelaccio, #frameworks, #dolphin, fvogt
Cc: dakon, fvogt, kde-frameworks-devel, bruns, meven, ltoscano, #frameworks, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180820/588ec378/attachment.htm>