D14980: Restore settings label and prevent warning when Baloo is unavailable

[Henrik Fehlauer]

rkflx created this revision.
rkflx added a reviewer: elvisangelaccio.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
rkflx requested review of this revision.

REVISION SUMMARY
  As discussed in D14814 <https://phabricator.kde.org/D14814>, 6674c9c387d0 <https://phabricator.kde.org/R318:6674c9c387d0986e99698332727bf797257bf07d> removed the Show tooltips
  checkbox in Dolphin's preferences when Baloo is unavailabe at compile
  time and thus the tooltip would not be functional. The Miscellaneous
  label in front of the checkbox was also removed, even though it relates
  to all options in that group.
  
  In addition, after 6674c9c387d0 <https://phabricator.kde.org/R318:6674c9c387d0986e99698332727bf797257bf07d> running Dolphin without Baloo support
  would print
  
    QWidget::insertAction: Attempt to insert null action
  
  on startup.
  
  Both issues can be fixed with more `#ifdefs`.

TEST PLAN
  After building with `-DCMAKE_DISABLE_FIND_PACKAGE_KF5Baloo=ON`, the
  Show tooltips checkbox is removed, the Miscellaneous label
  is still there, and there is no warning printed.

REPOSITORY
  R318 Dolphin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14980

AFFECTED FILES
  src/dolphinmainwindow.cpp
  src/settings/general/behaviorsettingspage.cpp

To: rkflx, elvisangelaccio
Cc: kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180821/50d2d253/attachment.htm>