D7847: Fix bug 158264 - Terminal panel (konsole part) blocks the umount of removable media

[Miklos Marton]

martonmiklos marked an inline comment as done.
martonmiklos added a comment.


  In https://phabricator.kde.org/D7847#146547, @elvisangelaccio wrote:
  
  > I'm not sure I agree with this patch.
  >  A standard  behavior in other filemanagers when umounting a device is to redirect to the view from the device URL to the home URL.
  >  So imho this patch is using the wrong approach: instead of the mainwindow telling the terminal panel to go to the home, it should be the mainwindow the one that changes its URL to the home.
  >
  > This way:
  >
  > 1. We get an usable DolphinView after unmounting the device (matching the behavior of e.g. Nautilus)
  > 2. We don't need the `goHome()` method in TerminalPanel, it would be automatic.
  
  
  Currently the mainwindow does not go anywhere (keep showing the mount path, but with empty contents) which is a rather odd behaviour I think.
  
  Give me some time to refactor the patch.
  
  Just to doublecheck what I would like to do:
  
  - If the unmount request come in (from two sources: panel unmount or the Solid::StorageAccess::teardownRequested) then the Dolphin shall:
    - Iterate through all open tabs of the Dolphin instance and if the current tab's path starts with the mounted path then that tab should be redirected to the home directory.
    - There is one corner case what I can think about: if there is a symlink to the mounted content this approach will fail. Technically we could iterate through the directory tree which make the path to see if it is a symlink and check if it points to the mount path, but I think that might not have much added value.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7847

To: martonmiklos, #dolphin
Cc: elvisangelaccio, emmanuelp, zhigalin, navarromorales, firef, andrebarros
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170917/87899792/attachment.htm>