D8454: Make Saved Search feature discoverable

Nathaniel Graham noreply at phabricator.kde.org
Wed Oct 25 14:26:43 BST 2017


ngraham added a comment.


  @emateli
  
  1. I agree that the icon isn't quite right. However, that's the way it already is; I didn't change that. And as I suspect that the fix there is in Breeze-icons, it would be out of scope for this patch (though I do want and plan to fix it).
  
  2. Same thing: for this patch, I didn't actually want to change anything about how saved searches are handled, just make the feature discoverable.
  
  3. The red close button is standard throughout KDE software, so I'm not sure we should change that. There is an outstanding request to make the toolbar's Find button a toggle (https://bugs.kde.org/show_bug.cgi?id=353227) which could eliminate the need for a separate close button as long as the Find button is on the toolbar, but if you remove it, then there is no only GUI method to hide the Find bar.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D8454

To: ngraham, #dolphin, #kde_applications, broulik, dfaure
Cc: emateli, elvisangelaccio, cfeck, #dolphin, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171025/54eaaa34/attachment.htm>


More information about the kfm-devel mailing list