D8454: Make Saved Search feature discoverable

[Mark Gaiser]

markg accepted this revision.
markg added a comment.
This revision is now accepted and ready to land.


  Ohhh! Nice addition!
  +1 for the idea. Code looks OK in my opinion.
  Don't push it right away, wait at least a few days or till someone else also gives a +1.

INLINE COMMENTS

> dolphincontextmenu.cpp:308
>                  PlacesItemModel model;
> -                const QString text = selectedUrl.fileName();
> -                PlacesItem* item = model.createPlacesItem(text, selectedUrl, KIO::iconNameForUrl(selectedUrl));
> +                const DolphinViewContainer* container =  m_mainWindow->activeViewContainer();
> +                PlacesItem* item = model.createPlacesItem(container->placesText(), selectedUrl, KIO::iconNameForUrl(selectedUrl));

A really minor nitpick..
Remove 1 space after the =
:)

REPOSITORY
  R318 Dolphin

BRANCH
  saved-searches

REVISION DETAIL
  https://phabricator.kde.org/D8454

To: ngraham, #dolphin, #kde_applications, broulik, dfaure, markg
Cc: markg, emateli, elvisangelaccio, cfeck, #dolphin, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171025/583ae42e/attachment.htm>