D7647: Two clicks on file/folder to rename

[Mark Gaiser]

markg requested changes to this revision.
markg added a comment.


  I'm OK with this feature after the code is correct.
  So with probably my suggestion and those of @elvisangelaccio

INLINE COMMENTS

> elvisangelaccio wrote in dolphinview.cpp:103
> We could also do:
> 
>   QTimer* m_twoClicksRenamingTimer = nullptr;
> 
> in `dolphinview.h` and drop the variable from the initializer list.

Most certainly not!
You would break initializing consistency by some being initialized in the header, most in the source.
By default (and by coding guidelines) we do the initializing part in the constructor.

You can change it to:
m_twoClicksRenamingTimer(new QTimet(this))

that would be OK imho.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7647

To: akrutzler, #dolphin, #kde_applications, elvisangelaccio, emmanuelp, ngraham, markg
Cc: rkflx, markg, funkybomber, sars, elvisangelaccio, ngraham, #konqueror
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171015/fd966983/attachment.htm>