D7647: Two clicks on file/folder to rename

[Mark Gaiser]

markg added inline comments.

INLINE COMMENTS

> markg wrote in dolphinview.cpp:103
> Most certainly not!
> You would break initializing consistency by some being initialized in the header, most in the source.
> By default (and by coding guidelines) we do the initializing part in the constructor.
> 
> You can change it to:
> m_twoClicksRenamingTimer(new QTimet(this))
> 
> that would be OK imho.

"Most certainly not!" was for the suggestion of initializing the member in the header, the comment from @elvisangelaccio

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7647

To: akrutzler, #dolphin, #kde_applications, elvisangelaccio, emmanuelp, ngraham, markg
Cc: rkflx, markg, funkybomber, sars, elvisangelaccio, ngraham, #konqueror
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171015/195d7990/attachment.htm>