D7647: Two clicks on file/folder to rename

Elvis Angelaccio noreply at phabricator.kde.org
Sun Oct 15 14:06:41 BST 2017


elvisangelaccio added inline comments.

INLINE COMMENTS

> akrutzler wrote in dolphinview.cpp:103
> Ok, but I actually don't know why initializing it as nullptr at this point, because it will be initialized  in the same constructor with "new QTimer(this)" afterwards anyway. I just wanted to stick to the current style.

We could also do:

  QTimer* m_twoClicksRenamingTimer = nullptr;

in `dolphinview.h` and drop the variable from the initializer list.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7647

To: akrutzler, #dolphin, #kde_applications, elvisangelaccio, emmanuelp, ngraham, markg
Cc: rkflx, markg, funkybomber, sars, elvisangelaccio, ngraham, #konqueror
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171015/d641b9b4/attachment.htm>


More information about the kfm-devel mailing list