D7647: Two clicks on file/folder to rename

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> akrutzler wrote in dolphinview.cpp:649
> I assume with "previous if block" you mean:
> 
>   if (items.count() == 1 && GeneralSettings::renameInline()) { ... }
> 
> That's actually not true, because imagine this case:
> 
> - select one item
> - click at text (timer starts 800ms)
> - during that 800ms: the user select multiple items
> - renaming box appears
> 
> I tried to abort the twoClicksRenaming (during that 800ms) if the selected item(s) have changed (like I do on focus-lost for example, line 822) but I couldn't find a proper way (signal/slot) how to do that. So I decided to check here, if the selected items have changed. And if there are more items selected, twoClicksRenaming should never trigger.
> 
> If I could abort twoClicksRenaming on item-selection-change, I wouldn't need m_twoClicksRenamingItemIndex either. There are signals which reports an item change but I couldn't use them because they were firing even if nothing changed at all.
> Maybe you can help me out there? :)

I see, then there should be a comment explaining this logic.

Btw which signals have you tried? What about `KItemListSelectionManager::selectionChanged`?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7647

To: akrutzler, #dolphin, #kde_applications, elvisangelaccio, emmanuelp, ngraham, markg
Cc: rkflx, markg, funkybomber, sars, elvisangelaccio, ngraham, #konqueror
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171015/9d60aa7d/attachment.htm>