Review Request 129789: Don't overwrite custom icons for show_hidden_files action

Elvis Angelaccio elvis.angelaccio at kde.org
Sat Jan 14 11:57:52 GMT 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129789/
-----------------------------------------------------------

(Updated Jan. 14, 2017, 11:57 a.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin and Emmanuel Pescosta.


Changes
-------

Submitted with commit 85121a8115c5a8b6b7c0a01073663d51bd64e6ae by Elvis Angelaccio to branch Applications/16.12.


Bugs: 374508
    https://bugs.kde.org/show_bug.cgi?id=374508


Repository: dolphin


Description
-------

The show_hidden_files action by default has two possible icons, depeding on the visibility of hidden files. But if the users selected a custom icon for this icon, they probably don't want to lose it when toggling the action.


Diffs
-----

  src/views/dolphinviewactionhandler.cpp 5c0b49cd206c371fd5dda83895dd93f9e1f37be2 

Diff: https://git.reviewboard.kde.org/r/129789/diff/


Testing
-------

Setting a custom icon as described in the bug now works.


Thanks,

Elvis Angelaccio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170114/c21ad6a9/attachment.htm>


More information about the kfm-devel mailing list