Review Request 129789: Don't overwrite custom icons for show_hidden_files action

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129789/#review102010
-----------------------------------------------------------


Ship it!




Ship It!

- Emmanuel Pescosta


On Jan. 7, 2017, 4:26 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129789/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2017, 4:26 p.m.)
> 
> 
> Review request for Dolphin and Emmanuel Pescosta.
> 
> 
> Bugs: 374508
>     https://bugs.kde.org/show_bug.cgi?id=374508
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> The show_hidden_files action by default has two possible icons, depeding on the visibility of hidden files. But if the users selected a custom icon for this icon, they probably don't want to lose it when toggling the action.
> 
> 
> Diffs
> -----
> 
>   src/views/dolphinviewactionhandler.cpp 5c0b49cd206c371fd5dda83895dd93f9e1f37be2 
> 
> Diff: https://git.reviewboard.kde.org/r/129789/diff/
> 
> 
> Testing
> -------
> 
> Setting a custom icon as described in the bug now works.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170114/4aa31da0/attachment.htm>