Review Request 129719: Dolphin: extend availability of "Open Path in New Tab" functionality

[Don Nguyen]

> On Jan. 1, 2017, 6:57 p.m., Emmanuel Pescosta wrote:
> > src/dolphinmainwindow.cpp, line 1177
> > <https://git.reviewboard.kde.org/r/129719/diff/1/?file=488217#file488217line1177>
> >
> >     Adding the same action twice should be avoided, adjust the text instead if required.

Could you explain how to do this?  I copied the design from the "Open in New Tab"/"Open in New Tabs" implementation.

>From dolphinmainwindow.cpp:
    QAction* openInNewTab = actionCollection()->addAction(QStringLiteral("open_in_new_tab"));
    openInNewTab->setText(i18nc("@action:inmenu", "Open in New Tab"));
    openInNewTab->setIcon(QIcon::fromTheme(QStringLiteral("tab-new")));
    connect(openInNewTab, &QAction::triggered, this, &DolphinMainWindow::openInNewTab);

    QAction* openInNewTabs = actionCollection()->addAction(QStringLiteral("open_in_new_tabs"));
    openInNewTabs->setText(i18nc("@action:inmenu", "Open in New Tabs"));
    openInNewTabs->setIcon(QIcon::fromTheme(QStringLiteral("tab-new")));
    connect(openInNewTabs, &QAction::triggered, this, &DolphinMainWindow::openInNewTab);


- Don


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129719/#review101708
-----------------------------------------------------------


On Dec. 29, 2016, 2:45 a.m., Don Nguyen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129719/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2016, 2:45 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> This patch converts the "Open Path in New Tab" function to a global action and adds a context menu item for when multiple items are selected in the search view.  This allows the function to be accessed via the toolbar(accessible outside of search context) and works on a selection.
> 
> 
> Diffs
> -----
> 
>   src/dolphincontextmenu.h f67300d 
>   src/dolphincontextmenu.cpp ed3f643 
>   src/dolphinmainwindow.h 7003e94 
>   src/dolphinmainwindow.cpp e5103fd 
> 
> Diff: https://git.reviewboard.kde.org/r/129719/diff/
> 
> 
> Testing
> -------
> 
> manual testing of single/multiple selection via context menu and toolbar
> make test passes
> 
> 
> File Attachments
> ----------------
> 
> Open Path in New Tabs
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/12/29/8dac26f7-aab3-4e78-87b3-cbe522c7d890__parentstabs.png
> 
> 
> Thanks,
> 
> Don Nguyen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170109/d8269537/attachment.htm>