Review Request 129712: Properly disable create_dir action

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129712/#review101709
-----------------------------------------------------------


Ship it!




Ship It!

- Emmanuel Pescosta


On Dec. 28, 2016, 3:38 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129712/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2016, 3:38 p.m.)
> 
> 
> Review request for Dolphin and Emmanuel Pescosta.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> `isFolderWritable` is set in DolphinView::updateWritableState according to KFileItemListProperties::supportsWriting(). However, `writing=true` does not imply `makedir=true`, in an ioslave's .protocol file. An example is the trash protocol.
> 
> So we need to enable the create_dir action only if the protocol is actually able to create folders.
> 
> CCBUG: 332463
> 
> 
> Diffs
> -----
> 
>   src/views/dolphinviewactionhandler.cpp 858f9299b 
> 
> Diff: https://git.reviewboard.kde.org/r/129712/diff/
> 
> 
> Testing
> -------
> 
> Go to Trash and press F10 with and without patch.
> 
> Note that the create_dir action is already disabled by KIO (you can check by showing the menubar and opening File -> Create New menu), yet it was still listening for shortcuts on the Dolphin side.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170101/8abbd56d/attachment.htm>