Review Request 129719: Dolphin: extend availability of "Open Path in New Tab" functionality
Emmanuel Pescosta
emmanuelpescosta099 at gmail.com
Sun Jan 1 18:57:36 GMT 2017
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129719/#review101708
-----------------------------------------------------------
src/dolphinmainwindow.cpp (line 1173)
<https://git.reviewboard.kde.org/r/129719/#comment68107>
Adding the same action twice should be avoided, adjust the text instead if required.
- Emmanuel Pescosta
On Dec. 29, 2016, 3:45 a.m., Don Nguyen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129719/
> -----------------------------------------------------------
>
> (Updated Dec. 29, 2016, 3:45 a.m.)
>
>
> Review request for Dolphin.
>
>
> Repository: dolphin
>
>
> Description
> -------
>
> This patch converts the "Open Path in New Tab" function to a global action and adds a context menu item for when multiple items are selected in the search view. This allows the function to be accessed via the toolbar(accessible outside of search context) and works on a selection.
>
>
> Diffs
> -----
>
> src/dolphincontextmenu.h f67300d
> src/dolphincontextmenu.cpp ed3f643
> src/dolphinmainwindow.h 7003e94
> src/dolphinmainwindow.cpp e5103fd
>
> Diff: https://git.reviewboard.kde.org/r/129719/diff/
>
>
> Testing
> -------
>
> manual testing of single/multiple selection via context menu and toolbar
> make test passes
>
>
> File Attachments
> ----------------
>
> Open Path in New Tabs
> https://git.reviewboard.kde.org/media/uploaded/files/2016/12/29/8dac26f7-aab3-4e78-87b3-cbe522c7d890__parentstabs.png
>
>
> Thanks,
>
> Don Nguyen
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170101/04d78616/attachment.htm>
More information about the kfm-devel
mailing list