Review Request 129712: Properly disable create_dir action

[Elvis Angelaccio]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129712/
-----------------------------------------------------------

(Updated Jan. 2, 2017, 1:55 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin and Emmanuel Pescosta.


Changes
-------

Submitted with commit 24ed38d77f4bc6db71ba2608452fa0cd401bddac by Elvis Angelaccio to branch Applications/16.12.


Repository: dolphin


Description
-------

`isFolderWritable` is set in DolphinView::updateWritableState according to KFileItemListProperties::supportsWriting(). However, `writing=true` does not imply `makedir=true`, in an ioslave's .protocol file. An example is the trash protocol.

So we need to enable the create_dir action only if the protocol is actually able to create folders.

CCBUG: 332463


Diffs
-----

  src/views/dolphinviewactionhandler.cpp 858f9299b 

Diff: https://git.reviewboard.kde.org/r/129712/diff/


Testing
-------

Go to Trash and press F10 with and without patch.

Note that the create_dir action is already disabled by KIO (you can check by showing the menubar and opening File -> Create New menu), yet it was still listening for shortcuts on the Dolphin side.


Thanks,

Elvis Angelaccio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170102/5fecdc56/attachment.htm>