Review Request 129705: [DolphinViewContainer] Show search view only if it's enabled

[Emmanuel Pescosta]

> On Jan. 1, 2017, 10:36 a.m., Anthony Fieroni wrote:
> > ping

Thanks for the patch and sorry for the late reply!

I think a better approach would be to override the hideEvent method in DolphinSearchBox. The hideEvent should just stop the timer.


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129705/#review101692
-----------------------------------------------------------


On Dec. 26, 2016, 2:20 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129705/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2016, 2:20 p.m.)
> 
> 
> Review request for Dolphin and Emmanuel Pescosta.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> SearchBox request for searching after 1 sec, if url is changed before that time search view is showed again, which is annoying.
> 
> 
> Diffs
> -----
> 
>   src/dolphinviewcontainer.cpp 4e625c7d8 
> 
> Diff: https://git.reviewboard.kde.org/r/129705/diff/
> 
> 
> Testing
> -------
> 
> Steps to reproduce:
> 1. Type in searchbox
> 2. Quick, before 1 sec timeout is reached, ckick in link in PanelFolder to change the url
> 3. Timeout is reached, search view is showed again, it's not desired.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170101/13f3e3f0/attachment.htm>