Review Request 128563: Preserve selected items when changing folders

[Martin Tobias Holmedahl Sandsmark]

> On Sept. 4, 2016, 12:47 p.m., Emmanuel Pescosta wrote:
> > src/dolphinviewcontainer.cpp, line 457
> > <https://git.reviewboard.kde.org/r/128563/diff/2/?file=473178#file473178line457>
> >
> >     Why?
> >     
> >     This breaks the state restoring, because updateViewState() will be called before the state is restored.

Otherwise neither the selected items or even the current item was restored without doing this, the current item was just set to the first item in the folder.

Without doing this, restoreState() never gets called when going back or forward in history.


> On Sept. 4, 2016, 12:47 p.m., Emmanuel Pescosta wrote:
> > src/views/dolphinview.cpp, lines 1197-1204
> > <https://git.reviewboard.kde.org/r/128563/diff/2/?file=473179#file473179line1197>
> >
> >     This code can be removed. DolphinView applies the state asynchronously (see updateViewState()) as soon as the directory loading has been finished.

I'm not sure I understand your comment, the whole point of this patch is to restore the selected items when restoring state (i. e. going back or forward in history). Without this the selected item(s) are not restored, and the current item is just the first item in the folder.


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128563/#review98870
-----------------------------------------------------------


On Aug. 6, 2016, 11:15 a.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128563/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2016, 11:15 a.m.)
> 
> 
> Review request for Dolphin, David Faure, Elvis Angelaccio, Emmanuel Pescosta, and Sune Vuorela.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Instead of just clearing the selection when going back and forth in history, it now preserves the selected items.
> 
> 
> Diffs
> -----
> 
>   src/dolphinviewcontainer.h 62f9110 
>   src/dolphinviewcontainer.cpp 1c43fc9 
>   src/views/dolphinview.cpp a737dd0 
> 
> Diff: https://git.reviewboard.kde.org/r/128563/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160904/5433ac5a/attachment.htm>