Review Request 123253: dolphin: Navigate to parent folder selects child folder

[Gregor Mi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123253/
-----------------------------------------------------------

(Updated Sept. 6, 2016, 10:17 a.m.)


Review request for Dolphin and Emmanuel Pescosta.


Changes
-------

Rename the signal as done here: https://git.reviewboard.kde.org/r/127111/


Bugs: 335616
    https://bugs.kde.org/show_bug.cgi?id=335616


Repository: dolphin


Description
-------

This is a first working implementation of the feature suggestion filed in the ticket https://bugs.kde.org/show_bug.cgi?id=335616: "Dolphin: Navigate to parent folder selects child folder".

In short, this is what is does: Whenever the dolphin view is initialized to show the contents of a new URL (e.g. "/home/x/test") it will be checked if the new URL is a parent of the previous displayed URL (e.g. "/home/x/test/documents/aaa"). If the check is successful, then the common child (in this example: "/home/x/test/documents/") folder item will be selected and scrolled into view.


Diffs (updated)
-----

  src/dolphinviewcontainer.h 62f91100e9e5d457edd6f4d927c87610335834d7 
  src/dolphinviewcontainer.cpp 8fea3ba9d0bb8389d89724b9f0cd74605c0286fe 

Diff: https://git.reviewboard.kde.org/r/123253/diff/


Testing
-------

- unit test passes
- Played around with dolphin: enter URL manually, navigate via click in the item view, navigate via click in kurlnavigator, navigate with Alt+Left, Alt+Right, Alt+up, Backspace

2016-02-18:
There is now a difference in selection behaviour when using history buttons vs. direct url entry:

* history buttons: mark the item as current instead of restoring the previous selection
* direct url entry: the child item is marked as current and selected

I personally prefer the selection because it is clearly visible. If it is ok I would try to adapt the history behaviour accordingly.
  Update: I just saw that the "File Open" dialog does not do any selection at all if navigated back via history buttons. I'll postpone further action on this side issue for now.


Thanks,

Gregor Mi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160906/0694d4ba/attachment.htm>