Review Request 128563: Preserve selected items when changing folders

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128563/#review98870
-----------------------------------------------------------




src/dolphinviewcontainer.cpp (line 455)
<https://git.reviewboard.kde.org/r/128563/#comment66565>

    Why?
    
    This breaks the state restoring, because updateViewState() will be called before the state is restored.



src/views/dolphinview.cpp (lines 1196 - 1203)
<https://git.reviewboard.kde.org/r/128563/#comment66564>

    This code can be removed. DolphinView applies the state asynchronously (see updateViewState()) as soon as the directory loading has been finished.


- Emmanuel Pescosta


On Aug. 6, 2016, 1:15 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128563/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2016, 1:15 p.m.)
> 
> 
> Review request for Dolphin, David Faure, Elvis Angelaccio, Emmanuel Pescosta, and Sune Vuorela.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Instead of just clearing the selection when going back and forth in history, it now preserves the selected items.
> 
> 
> Diffs
> -----
> 
>   src/dolphinviewcontainer.h 62f9110 
>   src/dolphinviewcontainer.cpp 1c43fc9 
>   src/views/dolphinview.cpp a737dd0 
> 
> Diff: https://git.reviewboard.kde.org/r/128563/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160904/a5668161/attachment.htm>