Review Request 123080: Save bookmarks when adding them via the context menu

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Sat Mar 21 16:29:47 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123080/
-----------------------------------------------------------

(Updated March 21, 2015, 4:29 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Changes
-------

Submitted with commit 89f912a3c7e8b88e07bfbe9774999dc5d103f122 by Emmanuel Pescosta to branch Applications/15.04.


Bugs: 345347
    http://bugs.kde.org/show_bug.cgi?id=345347


Repository: kde-baseapps


Description
-------

Save bookmarks when adding them via the context menu.

We have to call PlacesItemModel::saveBookmarks explicitly since https://git.reviewboard.kde.org/r/122640/ 
Maybe we should create a bookmarks service in future to encapsulate it.

FIXED-IN: 15.04
BUG: 345347


Diffs
-----

  dolphin/src/dolphincontextmenu.cpp e692c8f 

Diff: https://git.reviewboard.kde.org/r/123080/diff/


Testing
-------

"Add to places" works in the item and viewport context menu


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150321/d091f4ab/attachment.htm>


More information about the kfm-devel mailing list