Review Request 123080: Save bookmarks when adding them via the context menu

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123080/#review77872
-----------------------------------------------------------

Ship it!


Looks good!

Encapsulating the access to the bookmarks file is probably a good idea. Whenenver I had to work with the "Places" code, I also thought that having a wrapper class (maybe in KIO?) that provides a simple API to manipulate the "Places" would be great.

- Frank Reininghaus


On März 20, 2015, 11:02 vorm., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123080/
> -----------------------------------------------------------
> 
> (Updated März 20, 2015, 11:02 vorm.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 345347
>     http://bugs.kde.org/show_bug.cgi?id=345347
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Save bookmarks when adding them via the context menu.
> 
> We have to call PlacesItemModel::saveBookmarks explicitly since https://git.reviewboard.kde.org/r/122640/ 
> Maybe we should create a bookmarks service in future to encapsulate it.
> 
> FIXED-IN: 15.04
> BUG: 345347
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphincontextmenu.cpp e692c8f 
> 
> Diff: https://git.reviewboard.kde.org/r/123080/diff/
> 
> 
> Testing
> -------
> 
> "Add to places" works in the item and viewport context menu
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150321/f7c59c84/attachment.htm>