Review Request 123137: High DPI pixmap support in Dolphin

David Edmundson david at davidedmundson.co.uk
Thu Mar 26 15:51:08 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123137/
-----------------------------------------------------------

Review request for Dolphin, Christoph Feck and Marco Martin.


Repository: dolphin


Description
-------

Quite a lot of changes, Dolphin does a /lot/ of special pixmap caching and manipulating.

Changes are in branch davidedmundson/highdpi

----


Make KPixmapModifier::applyFrame handle high DPI images


Paint icons at the correct size


squash me with a some other commit in kitemlistwidgetinformant


Copy device pixel ratio from original pixmap inside KPixmapModifier::scale


Create drag pixmaps which match the device pixel ratio


Provide scaled pixmaps in the main file model


Enable high DPI pixmaps in Dolphin


Center align pixmaps in a high DPR friendly way


Diffs
-----

  src/kitemviews/kfileitemlistview.cpp d249bef 
  src/kitemviews/kfileitemmodelrolesupdater.cpp c18d658 
  src/kitemviews/kitemlistcontroller.cpp a9ebf97 
  src/kitemviews/kitemlistwidget.cpp 3eb6b1d 
  src/kitemviews/kstandarditemlistwidget.h 8264522 
  src/kitemviews/kstandarditemlistwidget.cpp f663b87 
  src/kitemviews/private/kpixmapmodifier.h e8ca11a 
  src/kitemviews/private/kpixmapmodifier.cpp c564ecc 
  src/main.cpp e8d6c2d 
  src/panels/information/pixmapviewer.cpp 0053e43 

Diff: https://git.reviewboard.kde.org/r/123137/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150326/aebcfda4/attachment.htm>


More information about the kfm-devel mailing list