Review Request 126439: Cleanup Places Panel context menus

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Wed Dec 23 18:01:05 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126439/#review90015
-----------------------------------------------------------

Ship it!


Nice! Thanks for porting it to KF5 :)

Would it be possible apply the "same" changes to KIO KF5 as well? ;)


src/panels/places/placespanel.cpp (line 168)
<https://git.reviewboard.kde.org/r/126439/#comment61688>

    url.scheme == "trash" ?


- Emmanuel Pescosta


On Dec. 20, 2015, 11:17 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126439/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2015, 11:17 p.m.)
> 
> 
> Review request for Dolphin and Emmanuel Pescosta.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> This is a port of Review 109015 to KF5. The screenshots are still valid except for the now removed menu headings (and of course Breeze ;)
> 
> 
> Diffs
> -----
> 
>   src/panels/places/placesitemmodel.cpp 0d8ac69 
>   src/panels/places/placespanel.cpp 50ed7e7 
> 
> Diff: https://git.reviewboard.kde.org/r/126439/diff/
> 
> 
> Testing
> -------
> 
> Works in the same way as the other patch did.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151223/a52f8aed/attachment.htm>


More information about the kfm-devel mailing list