Review Request 126439: Cleanup Places Panel context menus
Mark Gaiser
markg85 at gmail.com
Mon Dec 21 16:12:12 GMT 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126439/#review89834
-----------------------------------------------------------
+1 fomr me. Code looks ok, menus look clean and functional.
But i do prefer to keep "Add Entry...".
- Mark Gaiser
On dec 20, 2015, 10:17 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126439/
> -----------------------------------------------------------
>
> (Updated dec 20, 2015, 10:17 p.m.)
>
>
> Review request for Dolphin and Emmanuel Pescosta.
>
>
> Repository: dolphin
>
>
> Description
> -------
>
> This is a port of Review 109015 to KF5. The screenshots are still valid except for the now removed menu headings (and of course Breeze ;)
>
>
> Diffs
> -----
>
> src/panels/places/placesitemmodel.cpp 0d8ac69
> src/panels/places/placespanel.cpp 50ed7e7
>
> Diff: https://git.reviewboard.kde.org/r/126439/diff/
>
>
> Testing
> -------
>
> Works in the same way as the other patch did.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151221/030f5968/attachment.htm>
More information about the kfm-devel
mailing list