Review Request 109015: Cleanup Places Panel context menus

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/109015/
-----------------------------------------------------------

(Updated Dez. 20, 2015, 10:17 nachm.)


Status
------

This change has been discarded.


Review request for Dolphin, KDE Usability and Frank Reininghaus.


Bugs: 310764
    http://bugs.kde.org/show_bug.cgi?id=310764


Repository: kde-baseapps


Description
-------

This patch cleans up the places panel context menus by:
 - Removing the device name in all the entries, it just distracts and every … single … entry has them. (It is debateable whether that title is needed or fitting, I am not a huge fan of these)
 - Moving "Open in a new tab" to the top like in most other places in KDE (Unmount and Empty Trash are always above because they're more important) 
 - Moving Icon Size to the global context menu rather than the item context menu where it made no sense from a context perspective
 - Removed "Unlock panels" from item context menu (also no "contextual" thing)
 - Removed "Add Entry" from item context menu
 - Removed "Show all entries" from item context menu

See screenshot for direct comparison between all changed context menus.
Of course this makes Dolphin's places panel drift even further away from generic kdelibs places panel but they so different already …


Diffs
-----

  dolphin/src/panels/places/placesitemmodel.cpp 1acbb57 
  dolphin/src/panels/places/placespanel.cpp e23732c 

Diff: https://git.reviewboard.kde.org/r/109015/diff/


Testing
-------

Editing still works, hiding/showing items, showing all, changing icon size, emptying trash, mounting/unmounting.


File Attachments
----------------

Comparison (left old, right new)
  https://git.reviewboard.kde.org/media/uploaded/files/2013/02/18/cleanupplaces.png


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151220/ea84504b/attachment.htm>