Review Request 123883: DolphinSearchBox: Add a "More search tools..." menu button

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123883/#review89690
-----------------------------------------------------------



src/search/dolphinsearchbox.cpp (line 388)
<https://git.reviewboard.kde.org/r/123883/#comment61442>

    Move it into the lambda function, because:
    * it is only used in the lambda function
    * wastes memory/cpu when the menu is not used
    * has no autoreload as far as I know



src/search/dolphinsearchbox.cpp (line 389)
<https://git.reviewboard.kde.org/r/123883/#comment61441>

    button->setMenu does not take over the ownership, so please hand over a parent QObject to the ctor.
    
    ... and maybe do button->setMenu(new Menu) directly and only capture the button in the lambda, you can access the menu by using button->menu()



src/search/dolphinsearchbox.cpp (line 390)
<https://git.reviewboard.kde.org/r/123883/#comment61440>

    ?
    
    Just capture the this pointer in the lambda other lambda function


- Emmanuel Pescosta


On Nov. 19, 2015, 12:07 p.m., Gregor Mi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123883/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 12:07 p.m.)
> 
> 
> Review request for Dolphin and Emmanuel Pescosta.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Adds a "More search tools..." button to the DolphinSearchBox.
> 
> Additionally, moves the "More/Fewer options" button from right to left to reduce the mouse travelling distance when the dolphin is maximized on a large screen (see screenshots)
> 
> The current location url will be passed to the search tool to set the initial search root directory.
> 
> 
> Diffs
> -----
> 
>   src/search/dolphinsearchbox.cpp 743d9113a9ae0f7820d1bed594462a208b2883c3 
> 
> Diff: https://git.reviewboard.kde.org/r/123883/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Currently there is a long mouse traveling distance
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/8d717a70-215d-4587-89d0-2fee89263731__MoreOptionsTravellingDistance.png
> "More search tools" and the "More/fewer options" buttons moved more to the left
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/3009c4e7-5666-4377-bf39-5ec1967858e6__MoreSearchTools.png
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151218/7470f348/attachment.htm>