Review Request 121293: Fix bug 341411 - Going Up breaks titlebar

[Arjun AK]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121293/#review71110
-----------------------------------------------------------



dolphin/src/dolphintabwidget.cpp
<https://git.reviewboard.kde.org/r/121293/#comment49671>

    OT: Wouldn't url.host() be better here. If you have mulitle tabs, with each tab connected to different server but the same protocol (say ftp) then all the tabs will be called ftp.


- Arjun AK


On Nov. 30, 2014, 4:38 p.m., Arjun AK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121293/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2014, 4:38 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 341411
>     http://bugs.kde.org/show_bug.cgi?id=341411
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> From Qt documentation:
> >Note that, if this QUrl object is given a path ending in a slash, the name of the file is considered empty.
> 
> The trailing slash needs to be removed before `fileName()` is called.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.cpp 81aa1e8 
>   dolphin/src/dolphintabwidget.cpp b38cd51 
> 
> Diff: https://git.reviewboard.kde.org/r/121293/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20141130/a2a4e611/attachment.htm>