Review Request 121293: Fix bug 341411 - Going Up breaks titlebar

Arjun AK arjunak234 at gmail.com
Sun Nov 30 11:08:32 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121293/
-----------------------------------------------------------

(Updated Nov. 30, 2014, 4:38 p.m.)


Review request for Dolphin.


Changes
-------

Missed the tabbar


Bugs: 341411
    http://bugs.kde.org/show_bug.cgi?id=341411


Repository: kde-baseapps


Description
-------

>From Qt documentation:
>Note that, if this QUrl object is given a path ending in a slash, the name of the file is considered empty.

The trailing slash needs to be removed before `fileName()` is called.


Diffs (updated)
-----

  dolphin/src/dolphinmainwindow.cpp 81aa1e8 
  dolphin/src/dolphintabwidget.cpp b38cd51 

Diff: https://git.reviewboard.kde.org/r/121293/diff/


Testing
-------


Thanks,

Arjun AK

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20141130/a2ce9834/attachment.htm>


More information about the kfm-devel mailing list