Review Request 121293: Fix bug 341411 - Going Up breaks titlebar

[Emmanuel Pescosta]

> On Nov. 30, 2014, 12:14 p.m., Arjun AK wrote:
> > dolphin/src/dolphintabwidget.cpp, line 353
> > <https://git.reviewboard.kde.org/r/121293/diff/2/?file=331144#file331144line353>
> >
> >     OT: Wouldn't url.host() be better here. If you have mulitle tabs, with each tab connected to different server but the same protocol (say ftp) then all the tabs will be called ftp.

Yes, but I would go even further and always append the host to the each tab with non local urls. (This was the motivation for asking you about merging those two methods)
But we should discuss this topic on the ML instead.


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121293/#review71110
-----------------------------------------------------------


On Nov. 30, 2014, 12:08 p.m., Arjun AK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121293/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2014, 12:08 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 341411
>     http://bugs.kde.org/show_bug.cgi?id=341411
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> From Qt documentation:
> >Note that, if this QUrl object is given a path ending in a slash, the name of the file is considered empty.
> 
> The trailing slash needs to be removed before `fileName()` is called.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.cpp 81aa1e8 
>   dolphin/src/dolphintabwidget.cpp b38cd51 
> 
> Diff: https://git.reviewboard.kde.org/r/121293/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20141130/27e4689d/attachment.htm>