Review Request 120941: Fix unit test failures that result from incorrect KUrl -> QUrl porting

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120941/#review69667
-----------------------------------------------------------

Ship it!


Thanks for fixing the unit tests! :)

I think we should remove the -DQT_NO_URL_CAST_FROM_STRING from "remove definitions" in the cmake file, to avoid other string-url casting bugs. What do you think?

- Emmanuel Pescosta


On Nov. 2, 2014, 7:26 a.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120941/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2014, 7:26 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> https://git.reviewboard.kde.org/r/120650/ introduced a couple of unit test failures by replacing KUrl functions with QUrl functions which are not semantically equivalent. This patch fixes these.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/tests/kfileitemmodeltest.cpp 758699d 
> 
> Diff: https://git.reviewboard.kde.org/r/120941/diff/
> 
> 
> Testing
> -------
> 
> kfileitemmodeltest is down from 6 failures to 1 - the last one is there since the frameworks port was started. I'll try to have a look at that one soon.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20141102/29609afe/attachment.htm>