Review Request 120941: Fix unit test failures that result from incorrect KUrl -> QUrl porting

[Frank Reininghaus]

> On Nov. 2, 2014, 11:29 vorm., Emmanuel Pescosta wrote:
> > Thanks for fixing the unit tests! :)
> > 
> > I think we should remove the -DQT_NO_URL_CAST_FROM_STRING from "remove definitions" in the cmake file, to avoid other string-url casting bugs. What do you think?

That sounds like a good idea! I haven't tried it yet though - it could be that some more changes are required to make it compile if casting from QString to QUrl is disabled, but it will definitely help to prevent such problems in the future.


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120941/#review69667
-----------------------------------------------------------


On Nov. 2, 2014, 6:26 vorm., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120941/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2014, 6:26 vorm.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> https://git.reviewboard.kde.org/r/120650/ introduced a couple of unit test failures by replacing KUrl functions with QUrl functions which are not semantically equivalent. This patch fixes these.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/tests/kfileitemmodeltest.cpp 758699d 
> 
> Diff: https://git.reviewboard.kde.org/r/120941/diff/
> 
> 
> Testing
> -------
> 
> kfileitemmodeltest is down from 6 failures to 1 - the last one is there since the frameworks port was started. I'll try to have a look at that one soon.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20141104/f358c39d/attachment.htm>