Review Request 120941: Fix unit test failures that result from incorrect KUrl -> QUrl porting

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120941/
-----------------------------------------------------------

(Updated Nov. 2, 2014, 6:26 vorm.)


Review request for Dolphin.


Changes
-------

Actually, the old unit test failure had the same root cause - QUrl(name) was used instead of QUrl::fromLocalFile(name). It was just less obvious because the cast from QString to QUrl was done implicitly when calling KIO::rename(oldPath, newPath, KIO::HideProgressInfo).

With this version of the patch, all Dolphin unit tests pass :-)


Repository: kde-baseapps


Description
-------

https://git.reviewboard.kde.org/r/120650/ introduced a couple of unit test failures by replacing KUrl functions with QUrl functions which are not semantically equivalent. This patch fixes these.


Diffs (updated)
-----

  dolphin/src/tests/kfileitemmodeltest.cpp 758699d 

Diff: https://git.reviewboard.kde.org/r/120941/diff/


Testing
-------

kfileitemmodeltest is down from 6 failures to 1 - the last one is there since the frameworks port was started. I'll try to have a look at that one soon.


Thanks,

Frank Reininghaus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20141102/cc49f683/attachment.htm>