Review Request 110685: Make it possible to hide some plugins from the context menu unless explicitly enabled by the user

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110685/#review33341
-----------------------------------------------------------


This review has been submitted with commit b1aebb44d6863951841d857b84253a782d4138dc by Frank Reininghaus to branch master.

- Commit Hook


On May 28, 2013, 3:57 a.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110685/
> -----------------------------------------------------------
> 
> (Updated May 28, 2013, 3:57 a.m.)
> 
> 
> Review request for Dolphin and David Faure.
> 
> 
> Description
> -------
> 
> The KActivities plugin has been causing some trouble recently, see https://bugs.kde.org/show_bug.cgi?id=314575 . It can block the host application when the user tries to open the context menu.
> 
> Rather than simply banning this plugin, which uses the KAbstractFileItemAction API for things that it has IMHO not been designed for, from the context menu, I am proposing a compromise that at least only shows it in the context menu if it has been explicitly enabled by the user.
> 
> Depends on https://git.reviewboard.kde.org/r/110625/ and https://git.reviewboard.kde.org/r/110684/
> 
> 
> This addresses bug 314575.
>     http://bugs.kde.org/show_bug.cgi?id=314575
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphincontextmenu.cpp cddcc89 
>   dolphin/src/settings/services/servicessettingspage.cpp 48e816b 
>   lib/konq/konq_popupmenu.cpp f9639d8 
> 
> Diff: http://git.reviewboard.kde.org/r/110685/diff/
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130529/0ae43d63/attachment.htm>